Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publishing workflow #8

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Fix publishing workflow #8

merged 3 commits into from
Nov 6, 2024
+89 −43

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented Nov 5, 2024 •
edited
Loading

This PR:

  • removes the version from hyperlight-testing. Having would force us to publish the crate to crates.io.
  • remove the publishing of preview releases
  • adds the ability to run the workflow as a dry-run
  • publishes to crates.io instead of internal registry
  • adds fields to Cargo.toml needed for publishing to crates.io

@jprendes jprendes requested a review from simongdavies November 5, 2024 22:36
@jprendes jprendes force-pushed the jprendes/fix-publishing branch from 7287e26 to 57f19e8 Compare November 6, 2024 11:28
@jprendes jprendes requested a review from simongdavies November 6, 2024 11:45
@jprendes jprendes force-pushed the jprendes/fix-publishing branch from 57f19e8 to 57b632d Compare November 6, 2024 13:43
@jprendes
remove version from hyperlight-testing
be5df18 
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes
publish to crates.io
f3d84ec 
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes
add missing Cargo.toml fields for publishing to crates.io
520ab36 
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes jprendes force-pushed the jprendes/fix-publishing branch from 57b632d to 520ab36 Compare November 6, 2024 16:21
@jprendes
Copy link
Contributor Author

jprendes commented Nov 6, 2024

Example run of the CargoPublish workflow
https://github.com/hyperlight-dev/hyperlight/actions/runs/11707689680/job/32607645960#step:5:39

@jprendes jprendes merged commit 29c62dc into main Nov 6, 2024
16 checks passed
@jprendes jprendes deleted the jprendes/fix-publishing branch November 6, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simongdavies simongdavies simongdavies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprendes @simongdavies